Unity 2D Character controller bug problem

Unity Engine
1

Hi I have a problem with this script,the script is not bad but there are a bug where if you press A + Space and after D or the reverse,the player increases the speed, and does not change direction,please someone that help to solve this problem? The code:

using UnityEngine;
using System.Collections;
public class CharacterController2D : MonoBehaviour {
     public float upSpead;
     public float jumpSpead;
     public bool jumping = false;
     public bool grounded = false;
     public string sidesHit = "none";
     public Vector2 down;
     public Vector2 sides;
     public Vector2 sideLeft;
     public float skinWidth = 0.1f;
     public float InitalAcceleration = 500;
     public float airspeed = 500;
     public bool maxSpeed = false;
     Vector2 start;
     RaycastHit2D hit;
     void Start(){
         //start = transform.position;
         //start.y = transform.position.y - transform.localScale.y/2f;
         }
     void Update () {
     //Basic ground checking code with Physics2d raycasting
         sideLeft = transform.position;
         sideLeft.x = transform.position.x - transform.localScale.x / 2 - 0.1f;
         sides = transform.position;
         sides.x = transform.position.x + transform.localScale.x / 2 + 0.1f;
         start = transform.position;
         start.y = transform.position.y - transform.localScale.y/2f - 0.1f;
         Debug.DrawRay (start, -Vector2.up);
         Debug.DrawRay (new Vector2(start.x - transform.localScale.x/2, start.y), -Vector2.up);
         Debug.DrawRay (new Vector2(start.x + transform.localScale.x/2, start.y), -Vector2.up);
         Debug.DrawRay (sides, Vector2.right);
         Debug.DrawRay (sideLeft, -Vector2.right);
         if (Physics2D.Raycast (start, -Vector2.up, skinWidth).collider != null || Physics2D.Raycast (new Vector2(start.x + transform.localScale.x/2, start.y), -Vector2.up, skinWidth).collider != null || Physics2D.Raycast (new Vector2(start.x - transform.localScale.x/2, start.y), -Vector2.up, skinWidth).collider != null) {
                         grounded = true;
                 } else {
             grounded = false;
                 }
    
         if (Input.GetKeyUp(KeyCode.A) && grounded == true) {
             //Detect when certain keys are released to reset velocity
             //Reset the velocity to a number close to 0 to make a sudden stop, but ease out to fell smoother
             rigidbody2D.velocity = new Vector2(-2,0);
         }
         if (Input.GetKeyUp(KeyCode.D) && grounded == true) {
             rigidbody2D.velocity = new Vector2(2,0);
         }
         //Jumping Trigger
         if (Input.GetKeyDown (KeyCode.Space)) {
             if(grounded == true){
             jumping = true;
                 //Add the Initial Accleration to make the player shoot up, and then slow down, then fall
                 rigidbody2D.AddForce(new Vector2(0,InitalAcceleration));
             }
                 }
         if (Input.GetKeyUp (KeyCode.Space)) {
             jumping = false;
         }
         if (Input.GetKey (KeyCode.Space)) {
             if(jumping ==true){
                 //Detect if speed limit is reached, and then fall back down
             if(rigidbody2D.velocity.y >=10){
                 jumping = false;
                 }
                 rigidbody2D.AddForce(new Vector2(0,jumpSpead * Time.deltaTime));
                 }
             }
         //Detect sides by raycastting. Possibly can be used for wall jumping
         if (Physics2D.Raycast (sides, Vector2.right, skinWidth).collider != null) {
                         sidesHit = "right";
         } else if (Physics2D.Raycast (sideLeft, -Vector2.right, skinWidth).collider != null) {
             sidesHit = "left";
                 }
             else {
             sidesHit = "none";
            
         }
         Move ();
     }
     void Move(){
         //Move in air code
         if (Input.GetAxisRaw ("Horizontal") < 0 && grounded == false && maxSpeed == true) {
             rigidbody2D.AddForce(new Vector2(airspeed * Time.deltaTime,0));
                 }
         else if (Input.GetAxisRaw ("Horizontal") > 0 && grounded == false && maxSpeed == true) {
             rigidbody2D.AddForce(new Vector2(-airspeed * Time.deltaTime,0));
         }
         //Move Left/Right Code
         if (rigidbody2D.velocity.x >= 9 || rigidbody2D.velocity.x <= -9) {
                         maxSpeed = true;
                 } else {
             if(maxSpeed == true){
                 maxSpeed = false;
             }
                 }
        
         if (Input.GetAxisRaw ("Horizontal") < 0 && sidesHit != "left") {
             if (maxSpeed == false && grounded == false) {
                 rigidbody2D.AddForce(new Vector2(-airspeed * Time.deltaTime,0));
                 }else if(maxSpeed == false){
             rigidbody2D.AddForce(new Vector2(-upSpead * Time.deltaTime,0));
                 }
             }
         if (Input.GetAxisRaw ("Horizontal") > 0 && sidesHit != "right") {
             if (maxSpeed == false && grounded == false && Input.GetAxisRaw ("Horizontal") < 0) {
                 rigidbody2D.AddForce(new Vector2(airspeed * Time.deltaTime,0));
             }else if(maxSpeed == false){
             rigidbody2D.AddForce(new Vector2(upSpead * Time.deltaTime,0));
             }
         }
     }
}
2

Not sure what’s going wrong here, but there’s at least one path that will never executed:

         if (Input.GetAxisRaw ("Horizontal") > 0 && sidesHit != "right")
         {
             if (maxSpeed == false && grounded == false && Input.GetAxisRaw ("Horizontal") < 0)
             {
                 rigidbody2D.AddForce(new Vector2(airspeed * Time.deltaTime,0));
             }
             else if(maxSpeed == false)
             {
                 rigidbody2D.AddForce(new Vector2(upSpead * Time.deltaTime,0));
             }
         }

(because in the condition this “GetAxisRaw (“Horizontal”) < 0” will never be true)

3

I’ m sorry i not have deleted this part of code.
but the problem not is this string but is another, you can help me to found the problem?

4

Could you try the following code to check if the behaviour of the keys is as expected?

Declare the following private fields:

bool grounded = true;
bool jumping = false;
int keySpaceCounter = 0;

and use the following code to create the log entries:

string additionalText = "";
if (Input.GetKeyUp(KeyCode.A) && grounded == true)
{
    print(string.Format("KEY_UP: A / grounded: {0} / jumping: {1}", grounded.ToString(), jumping.ToString()));
}
if (Input.GetKeyUp(KeyCode.D) && grounded == true)
{
    print(string.Format("KEY_UP: D / grounded: {0} / jumping: {1}", grounded.ToString(), jumping.ToString()));
}
if (Input.GetKeyDown (KeyCode.Space))
{
    if(grounded == true)
    {
        jumping = true;
        additionalText = "CHANGED";
    }
    print(string.Format("KEY_DOWN: <space> / grounded: {0} / jumping: {1} {2}", grounded.ToString(), jumping.ToString(), additionalText));
}
if (Input.GetKeyUp (KeyCode.Space))
{
    jumping = false;
    print(string.Format("KEY_UP: <space> / grounded: {0} / jumping: {1} {2}", grounded.ToString(), jumping.ToString(), keySpaceCounter.ToString()));
    keySpaceCounter = 0;
}
if (Input.GetKey (KeyCode.Space))
{
    if (jumping == true)
    {
        jumping = false;
        additionalText = "CHANGED";
    }
    if (keySpaceCounter == 0)
    {
        print(string.Format("KEY: <space> / grounded: {0} / jumping: {1} {2}", grounded.ToString(), jumping.ToString(), additionalText));
    }
    keySpaceCounter++;
}

Run the script and check if the output in the log file matches your expectations.

5

I tried it, it seems that the problem is not that

6

Than I guess you should rephrase your problem with a bit more details. Maybe a step by step instruction how to reproduce it, what you expect and what happens.