WaitForSeconds(1) appears to be counting 2 secs every 1 sec?

Unity Engine
1

Hi - I have some code in my game that updates a countdown timer on the screen. This code has been in for a long time, over a year and was working until today. I updated to 2019.2 yesterday but not sure if that’s related. The countdown timer appeared to all of a sudden be counting down 2 seconds every 1 second. 40…38…36…34…32…etc when before it was 40…39…38…37…etc as I would expect. It doesn’t update every 2 secs, it updates every 1 second but with 2 sec jumps.

I put Debug.Log in the calls where it formats the seconds and updates the UI. I have found that it appears to now count 2 seconds every 1 sec with the timestamps on the Debug.Log calls to prove it. I’ve spent 2 hours trying to figure this out. Hoping someone has some insight as to why it would start doing this now?

4816181--461393--Capture1.PNG

Here’s a screenshots of the code:

4816181--461402--Capture2.PNG

4816181--461405--Capture3.PNG
4816181--461405--Capture3.PNG735×259 8.1 KB

4816181--461408--Capture4.PNG

Any help is appreciated. Thanks.

2

is CurrentSeconds static? Maybe you have 2 instances in your scene? You can right click the script in your project view and > Find all references in scene

3

in the picture you posted it seems to work fine… counts one by one.

4

If you look at the timestamps every 2 seconds has the same 1 second timestamp.

5

Good idea, let me make sure I’m only dealing with one instance.

Update: I verified there’s only one instance. I’m out of ideas.

6

Just to make sure, have you verified at runtime? As in rightclick the script and find references in scene while the game is running and you’re experiencing the double countdown.

7

Yes sir, there’s only one instance when I do what you advised both running the game and when it’s not running. I also tried changing it over to a static instance class and it’s still behaving the same way. Could this be a bug in 2019.2?

8

The only option left I can see is that you are running DecreaseTime twice. Can you post the entire class that contains the DecreaseTime coroutine?

9

I created a brand new project and tested a countdown timer and it works fine so it’s not a bug in Unity. It’s obviously getting called twice but I’m not sure how. Here’s the class:

public class Clock : MonoBehaviour
{
    static public Clock Instance;

    public int TotalSeconds;   
    private int CurrentSeconds;
    public ClockType ClockType;

    void Awake()
    {
        Instance = this;
    }

    void Start()
    {
        this.ClockType = ClockType.Play;       
        CurrentSeconds = 40;
        FormatUIClockDisplay();
    }

    public void StartClock()
    {
        Time.timeScale = 1;
        StartCoroutine("DecreaseTime");
    }
   
    public void StopClock()
    {
        StopCoroutine("DecreaseTime");
    }

    public void Update()
    {
       
    }

    public void Reset()
    {
        CurrentSeconds = 40;
    }

    public void FormatUIClockDisplay()
    {
        Debug.Log("Calling Scoreboard to update to: " + CurrentSeconds);
        UIManager.Instance.Scoreboard.SetPlayClock(string.Format("{0}", CurrentSeconds));
               
    }  

    IEnumerator DecreaseTime()
    {
        while(true)
        {
            yield return new WaitForSeconds(1);
            CurrentSeconds--;

            FormatUIClockDisplay();
            if (CurrentSeconds == 0)
            {
                this.StopClock();
                GameFlowManager.Instance.ClockHasExpired(this.ClockType);
            }
        }
    }
}
10

I’m guessing StartClock gets called twice. Try to put StopAllCoroutines(); right before StartCoroutine(DecreaseTime());

At least you’ll know if that’s the culprit. This will prevent the routine from running twice at the same time, at least in a single instance of the class.

11

Also I did a search through the entire project for references to DecreaseTime and found 3, all in this class:

4816349--461423--Capture5.PNG

And here’s the view when the game is running and I do a “Find References in Scene”:

4816349--461426--Capture6.PNG

12

StopAllCoroutines() made it stop skipping. I did a project search for StartClock() and it only found 1 place it’s called but that’s in an FSM so I need to dig deeper and see if that FSM is somehow getting instantiated twice. At least I’m on the right path. I really appreciate your help! Thank you!

1 Like