WaterSystemDef.cs

Unity Engine
,
1

Hello Unity Beta Team,
Please can you pass this along to the team working on water systems.
I like to give a heads up to unity that WaterSystemDef.cs will likely conflict with multiple developer’s assets and or any shaders ever made by unity users.

First found in 2023.3.0b3
for this example, we will look at case use:

Generated from UnityEngine.Rendering.HighDefinition.ShaderVariablesWater
float _FoamSmoothness;
float _WaterSmoothness;

above are very commonly used by countless assets over the years.
with WaterSystemDef.cs they will all get redefinition errors 2023.3.0b3

Suggestion
consider use a namespace or use something not so commonly used by so many others.

Cheers

2

@BenCloward
for your info see above this will also break Shader Graph.

to replicate in SG
— 2023.3.0b3
— open new graph add float _WaterSmoothness
and or
— open new graph add float _FoamSmoothness
— set on a material with surface type Transparent
— observe error and pink

Cheers