What's causing issues in my code?

Unity Engine
1

So I followed a tutorial to a T and somehow wound up with a whopping 32 errors. I went through all the errors one by one, and eventually brought it down it 5. However, I can’t seem to fix these remaining errors. I was hoping I could get some help here.

The current errors are:
Assets\PlayerMovement.cs(21,3): error CS1519: Invalid token ‘if’ in class, struct, or interface member declaration
Assets\PlayerMovement.cs(21,21): error CS8124: Tuple must contain at least two elements.
Assets\PlayerMovement.cs(21,41): error CS1003: Syntax error, ‘(’ expected
Assets\PlayerMovement.cs(21,41): error CS1001: Identifier expected
Assets\PlayerMovement.cs(21,58): error CS1001: Identifier expected

and my code is
using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class PlayerMovement : MonoBehaviour
{
public float speed = 10f;

Vector2 lastClickedPos;

bool moving;

private void Update()
{if (Input.GetMouseButtonDown(0)); {
lastClickedPos = Camera.main.ScreenToWorldPoint(Input.mousePosition);
then
moving = true;}

}

if (moving Vector2)transform.position != lastClickedPos)
{
float step = speed * Time.deltaTime;
(transform.position = Vector2.moveTowards)(transform.position, lastClickedPos, step;)}}

Thank you in advance, I really appreciate any help anyone can provide.

2

Next time, please post your script in code tags. It allows us to see the line numbers and find the error lines quicker.
However you have a couple of mistakes I can instantly see:
Remove the ; from this line {if (Input.GetMouseButtonDown(0)); {
You cannot use then in C#. I’m assuming it shouldn’t be there?
This line if (moving Vector2)transform.position != lastClickedPos) looks completely wrong, and so does this line (transform.position = Vector2.moveTowards)(transform.position, lastClickedPos, step;)}}

I’m going to go out on a limb here and say you have not followed the tutorial exactly, unless the tutorial is completely broken - in which case you should stay as far away from it as possible.

3

Use code tags

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class PlayerMovement : MonoBehaviour
{
public float speed = 10f;

Vector2 lastClickedPos;

bool moving;

private void Update()
{if (Input.GetMouseButtonDown(0)); {
lastClickedPos = Camera.main.ScreenToWorldPoint(Input.mousePosition);
then
moving = true;}

}

if (moving Vector2)transform.position != lastClickedPos)
{
float step = speed * Time.deltaTime;
(transform.position = Vector2.moveTowards)(transform.position, lastClickedPos, step;)}}
1 Like
4

And what happens when you correct those lines that I pointed out?
Are you able to provide a link to the tutorial?

5

While you did a great job in pointing out the what I need to fix, you didn’t exactly specify the how. As for deleting the colon, nothing happened. Here’s the tutorial:
https://www.youtube.com/watch?v=lCfoU1WoOhI

Obviously, some of the code is altered, due to my royally unsuccessful debugging work.

6

What in God’s name is a “Code tag”?

7

You would be advised to look at the lines mentioned previously and then carefully compare them to the video. For example look at 2:49 in the video at line 11 and compare to yours. Don’t alter any of the code until you get it working exactly as presented in the video.

8

The how would be to go back to the tutorial and actually type in what it says to type in, not random brackets or incorrect syntax or typos.
I just randomly jumped to different timestamps in that video and I can clearly see that you are not typing in a lot of what they did - so the mistakes are all your typos, and therefore you should go back through the tutorial and do it correctly.

1 Like
9

See how nicely formatted the code in Rin-Dev’s post is? That was posted using code tags. Now look at how your original post looks, that is without code tags.
How to use code tags is part of the guidelines/rules of the forum that you should be following. Go look at that the top stickied topic in this forum section to read all about how to post code using code tags.
https://discussions.unity.com/t/481379

2 Likes
10

We don’t need the tutorial. YOU need the tutorial. You also need to learn how to do tutorials, and also need to stop making so many typing mistakes.

Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

How to do tutorials properly, two (2) simple steps to success:

Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That’s how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.
Fortunately this is the easiest part to get right: Be a robot. Don’t make any mistakes.
BE PERFECT IN EVERYTHING YOU DO HERE!!

If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there’s an error, you will NEVER be the first guy to find it.

Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

Finally, when you have errors…

Remember: NOBODY here memorizes error codes. That’s not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

The complete error message contains everything you need to know to fix the error yourself.

The important parts of the error message are:

  • the description of the error itself (google this; you are NEVER the first one!)
  • the file it occurred in (critical!)
  • the line number and character position (the two numbers in parentheses)
  • also possibly useful is the stack trace (all the lines of text in the lower console window)

Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don’t have to stop your progress and fiddle around with the forum.

1 Like