Why does my script not work despite no errors?

Unity Engine
1

Hello, I have created a script that has no errors and everything is properly referenced to it, but it just refuses to do what it is told…

I know this is vague, but it is all I can really say about it: No errors, variables are set and referenced, doesn’t work at all.

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class Bomb : MonoBehaviour
{
    public GameObject Explosion;
    public GameObject Trigger;
    public Rigidbody rb;
    public MeshRenderer mr;
    public bool ready = false;

    void Start() {
        rb = GetComponent<Rigidbody>();
        Invoke("ResetColl" , 0.05f);
    }

    private void ResetColl() {
        ready = true;
    }

    public void OnCollisionEnter(Collision bombCollision) {
        if (ready) {
            Explosion.SetActive(true);

            Invoke("EndMovement" , 0.5f);
            Invoke("DestroySelf", 3f);
        }
    }
    public void OnCollisionExit() {
        ready = false;
    }

    public void EndMovement() {
        rb.constraints = RigidbodyConstraints.FreezePositionX | RigidbodyConstraints.FreezePositionY | RigidbodyConstraints.FreezePositionZ | RigidbodyConstraints.FreezeRotationX | RigidbodyConstraints.FreezeRotationY | RigidbodyConstraints.FreezeRotationZ;
        mr.enabled = false;
        Trigger.SetActive(true);
    }

    public void DestroySelf() {
        Destroy(gameObject);
    }
}
2

Yes it is. You didn’t say what it was expected to do and what it is doing. Not working could mean anything. :wink:

3

I’ll add my obligatory hatred for Coroutines here and stop. The patterns in this code are designed around obfuscating what happens and what’s expected.

4

The red-dot syntax errors are the simplest part of programming – things like “lines end in semicolons” and “if’s need ()'s around the thing they check”. They barely even count as programming. They’re more like learning spelling and grammar. It seems like a lot to learn, and it is, but just like spelling and remembering “noun verb subject”, you’ll quickly memorize programming syntax. Some of it will even start to make sense (like how {}'s are for grouping, which means they work the same for functions, if’s and even loops).

Then you’re ready to start learning programming. And that thing you have looks like a lot. It uses Unity Collisions, which probably have to be set up a certain way. It assumes you have other things hooked-up properly. And if you got if off the internet there’s a good change it never worked in the first place.

5

+1 for that…

Hey, OP, if you’re serious about doing something, take a moment and get inspired here:

Imphenzia: How Did I Learn To Make Games:

https://www.youtube.com/watch?v=b3DOnigmLBY

Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

How to do tutorials properly, two (2) simple steps to success:

Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That’s how software engineering works. Every step must be taken, every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly, literally NOTHING can be omitted or skipped.

Fortunately this is the easiest part to get right: Be a robot. Don’t make any mistakes.
BE PERFECT IN EVERYTHING YOU DO HERE!!

If you get any errors, learn how to read the error code and fix your error. Google is your friend here. Do NOT continue until you fix your error. Your error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there’s an error, you will NEVER be the first guy to find it.

Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!