Why Music Player Pause and Stop Buttons Do Not Work As They Should

Questions & Answers
1

I have this music player script that when it plays the next song from the music folder it makes my Pause and stop buttons not work quite right. wondering if anyone can take a look and see why?

UPDATE: I updated the script The main problem is solved now. Now the Stop and Pause buttons are functioning the way they should. What a pain in the you know what, all day to do something that should have taken 5 minutes. Gee thankx :confused:

using UnityEngine;
using System.Collections;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using UnityEngine.UI;

public class AltMusicPlayer : MonoBehaviour
{

public Text MusicListText;// Reference to my UI Display Text for Songs
private string display = "";//NEW Delete if does not work!!
public enum SeekDirection { Forward, Backward }

public AudioSource source;

bool playing = true;

public List<AudioClip> clips = new List<AudioClip>();

[SerializeField] [HideInInspector] private int currentIndex = 0;

private FileInfo[] soundFiles;
private List<string> validExtensions = new List<string> { ".ogg", ".wav" }; // Don't forget the "." i.e. "ogg" won't work - cause Path.GetExtension(filePath) will return .ext, not just ext.
private string absolutePath = "./Audio/Music"; // relative path to where the app is running - change this to "./music" in your case

void Start()
{
	//being able to test in unity
	if (Application.isEditor)
		absolutePath = "Assets/Audio/Music";
	
	if (source == null)
		source = gameObject.AddComponent<AudioSource> ();
	ReloadSounds ();
}


void Update(){
	if(!source.isPlaying && playing)
	{
		Seek(SeekDirection.Forward);
		PlayCurrent();
	}
}



//My New UI Buttons Added
public void PlayPrevious (){
	Seek(SeekDirection.Backward);
	PlayCurrent();
}

public void PlayCurrentClip () {
	PlayCurrent();
	playing = true;
}

public void PlayNext () {
	Seek(SeekDirection.Forward);
	PlayCurrent();
}

public void ReloadAudio () {
	ReloadSounds();
}

public void StopAudio () {
		source.Stop ();
		playing = false;
	
}

public void PauseAudio () {
	source.Pause ();
	playing = false;

}

void Shuffle()
{
	//Shuffle or Randomize Songs in Array List
	//ShuffleMusic();
}

//End My New UI Buttons Added

void Seek(SeekDirection d)
{
	if (d == SeekDirection.Forward)
		currentIndex = (currentIndex + 1) % clips.Count;
	else {
		currentIndex--;
		if (currentIndex < 0) currentIndex = clips.Count - 1;
	}
}

void PlayCurrent()
{
	source.clip = clips[currentIndex];
	source.Play();
	Debug.Log (source.clip);
	MusicListText.text = clips[currentIndex].name;

}


void ReloadSounds()
{
	clips.Clear();
	
	// get all valid files
	var info = new DirectoryInfo(absolutePath);
	soundFiles = info.GetFiles()
		.Where(f => IsValidFileType(f.Name))
			.ToArray();
	
	// and load them
	foreach (var s in soundFiles)
		StartCoroutine(LoadFile(s.FullName));
}

bool IsValidFileType(string fileName)
{
	return validExtensions.Contains(Path.GetExtension(fileName));
	// Alternatively, you could go fileName.SubString(fileName.LastIndexOf('.') + 1); that way you don't need the '.' when you add your extensions
}

IEnumerator LoadFile(string path)
{
	WWW www = new WWW("file://" + path);
	print("loading " + path);
	
	AudioClip clip = www.GetAudioClip(false);
	while(!clip.isReadyToPlay)
		yield return www;
	
	print("done loading");
	clip.name = Path.GetFileName(path);
	clips.Add(clip);

	//Count Array List Length
	//source.clip = clips[currentIndex];
	Debug.Log (clip);
	//int List = clips.Count;
	//Debug.Log (List);
}

//NEW
void AddText()
{
	display = currentIndex + " : " + clips[currentIndex].name;
	MusicListText.text = display;
}
//END NEW

//Quit Button
public void  GoQuit(){
	StartCoroutine(LoadQuit("MainScreen"));
}

IEnumerator LoadQuit(string levelMain){
	yield return new WaitForSeconds(0.5f); // wait time
	Application.LoadLevel(levelMain);
	
}

}

2

I can’t tell where these functions are all being called (I’m guessing a UI front-end hooks into it), but you should be able to have the player continue to the next song by adding this method to the script:

void Update(){
   if(!source.isPlaying)
   {
       Seek(SeekDirection.Forward);
       PlayCurrent();
   }
}
3

Just for the heck of it I’ll add the slightly modified script in @callen so you can see the changes.
It’s working better but still a little goofy. Oh just in case I didn’t mention it the button are on a UI canvas. :wink:

using UnityEngine;
using System.Collections;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using UnityEngine.UI;

public class AltMusicPlayer : MonoBehaviour
{

	public Text MusicListText;// Reference to my UI Display Text for Songs
	private string display = "";//NEW Delete if does not work!!
	public enum SeekDirection { Forward, Backward }
	
	public AudioSource source;

	bool playing = true;

	public List<AudioClip> clips = new List<AudioClip>();
	
	[SerializeField] [HideInInspector] private int currentIndex = 0;
	
	private FileInfo[] soundFiles;
	private List<string> validExtensions = new List<string> { ".ogg", ".wav" }; // Don't forget the "." i.e. "ogg" won't work - cause Path.GetExtension(filePath) will return .ext, not just ext.
	private string absolutePath = "./Audio/Music"; // relative path to where the app is running - change this to "./music" in your case

	void Start()
	{
		//being able to test in unity
		if (Application.isEditor)
			absolutePath = "Assets/Audio/Music";
		
		if (source == null)
			source = gameObject.AddComponent<AudioSource> ();
		ReloadSounds ();
	}
	

	void Update(){
		if(!source.isPlaying && playing)
		{
			Seek(SeekDirection.Forward);
			PlayCurrent();
		}
	}
	
	
	
	//My New UI Buttons Added
	public void PlayPrevious (){
		Seek(SeekDirection.Backward);
		PlayCurrent();
	}

	public void PlayCurrentClip () {
		PlayCurrent();
		playing = true;
	}

	public void PlayNext () {
		Seek(SeekDirection.Forward);
		PlayCurrent();
	}

	public void ReloadAudio () {
		ReloadSounds();
	}

	public void StopAudio () {
			
			playing = false;
		
	}

	void Shuffle()
	{
		//Shuffle or Randomize Songs in Array List
		//ShuffleMusic();
	}


	//End My New UI Buttons Added
	
	void Seek(SeekDirection d)
	{
		if (d == SeekDirection.Forward)
			currentIndex = (currentIndex + 1) % clips.Count;
		else {
			currentIndex--;
			if (currentIndex < 0) currentIndex = clips.Count - 1;
		}
	}
	
	void PlayCurrent()
	{
		source.clip = clips[currentIndex];
		source.Play();
		Debug.Log (source.clip);
		MusicListText.text = clips[currentIndex].name;


	}
	

	void ReloadSounds()
	{
		clips.Clear();
		
		// get all valid files
		var info = new DirectoryInfo(absolutePath);
		soundFiles = info.GetFiles()
			.Where(f => IsValidFileType(f.Name))
				.ToArray();
		
		// and load them
		foreach (var s in soundFiles)
			StartCoroutine(LoadFile(s.FullName));
	}
	
	bool IsValidFileType(string fileName)
	{
		return validExtensions.Contains(Path.GetExtension(fileName));
		// Alternatively, you could go fileName.SubString(fileName.LastIndexOf('.') + 1); that way you don't need the '.' when you add your extensions
	}
	
	IEnumerator LoadFile(string path)
	{
		WWW www = new WWW("file://" + path);
		print("loading " + path);
		
		AudioClip clip = www.GetAudioClip(false);
		while(!clip.isReadyToPlay)
			yield return www;
		
		print("done loading");
		clip.name = Path.GetFileName(path);
		clips.Add(clip);


		//Count Array List Length
		//source.clip = clips[currentIndex];
		Debug.Log (clip);
		//int List = clips.Count;
		//Debug.Log (List);
	}

	//NEW
	void AddText()
	{
		display = currentIndex + " : " + clips[currentIndex].name;
		MusicListText.text = display;
	}
	//END NEW

	//Quit Button
	public void  GoQuit(){
		StartCoroutine(LoadQuit("MainScreen"));
	}
	
	IEnumerator LoadQuit(string levelMain){
		yield return new WaitForSeconds(0.5f); // wait time
		Application.LoadLevel(levelMain);
		
	}


}