Yield Function Freezes Game?

Unity Engine
1

Can anyone please explain to me why the Yield Function Freezes My Game? I’m trying to Respawn a Player Upon Death. Naturally we want to WaitforSeconds while the Player’s Death Animation is Played and Clamped Until Timer is Up and we continue to Respawn the Player. In the following Script, if I change the Respawn() to void, and comment out the yield function, the Respawn Works Instantaly (No Player Death Animation Played). If I set this Respawn() as IEnumerator with yield return new WaitForSeconds(3); it still works, only the game Freezes entirely for 3 seconds then respawns the player. Doesn’t make much sense to me… please help!

    [RPC]
    IEnumerator Respawn()
    {
        if (photonView.isMine)
        {
            theScoreBoard.LocalPlayerDied();
        }
        transform.parent.GetChild(0).gameObject.SetActive(false);
        GetComponent <CharacterController> ().enabled = false;
        GetComponent<PlayerAnimation>().Dead();
        dead = true;
     
        yield return new WaitForSeconds(3);

        foreach (Transform child in transform)
        {
            child.gameObject.SetActive(false);
        }
        // Randomize starting location
        if(photonView.isMine)
        {
            GameObject[] spawnpoints = GameObject.FindGameObjectsWithTag("Spawnpoint");
            Transform spawnpoint = spawnpoints[Random.Range(0, spawnpoints.Length)].transform;
         
            photonView.RPC("Revive",PhotonTargets.All,spawnpoint.position, spawnpoint.rotation);
        }
    }
2

I see a [RPC] above. Could you perhaps try something like this:

    [RPC]
    void Respawn()
    {
          StartCoroutine( RespawnSequence() );
    }

    IEnumerator RespawnSequence()
    {
        if (photonView.isMine)
        {
            theScoreBoard.LocalPlayerDied();
        }
        transform.parent.GetChild(0).gameObject.SetActive(false);
        GetComponent <CharacterController> ().enabled = false;
        GetComponent<PlayerAnimation>().Dead();
        dead = true;
   
        yield return new WaitForSeconds(3);
        foreach (Transform child in transform)
        {
            child.gameObject.SetActive(false);
        }
        // Randomize starting location
        if(photonView.isMine)
        {
            GameObject[] spawnpoints = GameObject.FindGameObjectsWithTag("Spawnpoint");
            Transform spawnpoint = spawnpoints[Random.Range(0, spawnpoints.Length)].transform;
       
            photonView.RPC("Revive",PhotonTargets.All,spawnpoint.position, spawnpoint.rotation);
        }
    }

Basically call RPC to StartCoroutine( RespawnSequence() ). I never tried calling photonView.RPC() on a coroutine function so I can’t tell why exactly is that happening.

3

Thanks, I tried it but nope doesn’t work… I get the same results. Here is Screenshot for better visual of whats happening when this Script Runs. I don’t even think this is a Networking Issue at all, as the Respawn Works Perfectly Fine. The main issue is Client B as shown below just Freezes for 3 Seconds instead of showing the Player’s Death Animation. Oddly enough I can see the Player Die on Client A (Death Animation Plays Back but for some odd reason Plays returns to Idle State then Respawns, but that’s another issue I think). Main problem is Freezing due to the Yield Function. Once I comment out Yield and Remove Couroutine everything works fine, no freezing at all…

2108842--138289--frozen.jpg

4

Hmm that does not make any sense :eyes: If I had to start somewhere, I would check those functions inside photonView.isMine:

        if (photonView.isMine)
        {
            theScoreBoard.LocalPlayerDied();
        }
     

        // Randomize starting location
        if(photonView.isMine)
        {
            GameObject[] spawnpoints = GameObject.FindGameObjectsWithTag("Spawnpoint");
            Transform spawnpoint = spawnpoints[Random.Range(0, spawnpoints.Length)].transform;
    
            photonView.RPC("Revive",PhotonTargets.All,spawnpoint.position, spawnpoint.rotation);
        }

They look most likely like culprit since the other player never calls them and his screen does not freeze. Good luck!

5

Well the weird thing is, as mentioned if I remove the Couroutine, the respawn functions that are inside the photonView.isMine as you point out above works just fine. There is no freezing at all if I remove the Yield. So for me that indicates there is no problem with the re-spawn functions, but maybe i’m looking at this the wrong way lol, and maybe it is some kind of Networking issues I don’t understand. I wish I would get some console errors, but I don’t… = (

6

Sorry I only have some debugging ideas:
What happens if you yield return WaitForSeconds(0)?
Are you certain the game is frozen? If client A is moving around does client B see that?
Perhaps there is a problem with playing the animation on the local client.
you could also try 3x yield return WaitForSeconds(1) with debug lines between

1 Like
7

You’re still not really providing enough information. What does PlayerAnimation.Dead() do? Is A the one dying or is B the one dying? In those instances, who is invoking Respawn? When you say “freeze” what do you mean? Unity’s RPC does not support coroutines - have you checked Photon documentation to see if it is supported there? Have you checked the “frozen” client log for exceptions that would halt execution? IE - one red flag to me would be looking for a CharacterController on client instances that don’t own the player object being killed. If that failed then Dead() would never be called and your “frozen” state would just be the time spent yielding in the caller’s RPC method before they sent the actual Revive RPC.

1 Like
8

Thank you! Lots of Questions to Answer lol… I’ll reply shortly once I have a free moment here at work in the Office.

day job… bla :face_with_spiral_eyes:

9

What does PlayerAnimation.Dead() do?

Calls Dead Animation State, and Plays Player Animation

Is A the one dying or is B the one dying?

In the example screenshot above, B is dying and is laying on the ground.

In those instances, who is invoking Respawn?

Client B is invoking Respawn since the Respawn is scripted into the Player script that checks if HP is equal to 0

When you say “freeze” what do you mean?

Client B remains uncontrollable, and all objects in the scene just stops (example other players, or any visable dynamic objects in Client B’s view will remain frozen for 3 seconds as the Coroutine completes then Respawns Player (Client B).

Unity’s RPC does not support coroutines - have you checked Photon documentation to see if it is supported there?

According to this Photon Support thread I found it does seem like Coroutine is supported in RPC.

Have you checked the “frozen” client log for exceptions that would halt execution?

Yes, I should check that! Good idea… :slight_smile:

10

Keep in mind also that if you disable (.SetActive(false)) the actual game object upon which this respawn script is running, the Coroutine will stop… that would not cause a freeze, but it is just something to keep in mind.(Disclaimer: I did not read your code close enough to see if that might be the case.)

1 Like