While searching for a solution to a bug in my game I ran across this page saying that foreach loops are buggy and shouldn’t be used. However, this post is a couple of years old. Does anybody know if this bug still exists?
Additionally, will the unityscript’s for (var in container) syntax have the same problems since they compile to the same bytecode?
I read the forum thread in your link, and I think the juice in this issue is that:
Therefore, if you don’t use struct collections, this issue does not apply. And if you use struct collections minimally, and infrequently, the impact on performance will be minimal and most probably unnoticeable.
A mono upgrade in Unity has not happened yet, and will not happen until IL2CPP is mature and used on all required platforms:
https://www.reddit.com/r/Unity3D/comments/2e4q6c/unity_upgrading_to_c_5_and_net_45/
Here is a link to Unity Roadmap, if you want to follow the developments:
They upgrade the mono compiler (but not the runtime) in 5.5 (Unity 5.5 is ready for you | Unity Blog) and that means foreach is much better, including being 0-alloc for Lists: http://jacksondunstan.com/articles/3805
The way the compiler handles iterators in foreach loops generates unnecessary memory allocations. Remember you should reduce memory allocations to minimize the Garbage Collector load. It usually won’t be a problem when you use foreach to do initializations, but it may allocate too much memory when called constantly (every frame).
I think you will have the same problem with UnityScript’s for (var in container)
I recommend you to check the GC Alloc column in the Profiler. It will tell you when allocations are made in your foreach loops.