Raycast Else not working.

Archived Forums Questions & Answers
1

I’m having an error in my raycast code. It seems that i cannot use else in raycast?
Or is there something else wrong in this code.

 public Transform player;
	
 public bool canSee = false;
  

    void OnWillRenderObject() {

        RaycastHit hit;

        if (Physics.Raycast(player.position, (transform.position - player.position).normalized, out hit)) {

            if (hit.collider.gameObject == gameObject) {
				canSee = true;
			

        }
            else{
              canSee = false;
				
		if(canSee == false){
		Debug.Log ("Player not in sight :(");
			
		}else{
		Debug.Log ("Player in sight attack >:D");

    }
   }
  }
}

1 Answer

1
2

The code is wrong: you’ve not closed the first else correctly. The code should be:

void OnWillRenderObject() {
    RaycastHit hit;
    if (Physics.Raycast(player.position, (transform.position - player.position).normalized, out hit)) {
        if (hit.collider.gameObject == gameObject) {
            canSee = true;
        } else {
            canSee = false;
        } // <= this closing brace was missing or misplaced
        if (canSee == false){
            Debug.Log ("Player not in sight :(");
        } else {
            Debug.Log ("Player in sight attack >:D");
        }
    }
}

Why are you placing this code inside OnWillRenderObject? This event only occurs when the object is inside the viewing angle of any camera. Is this a desired feature?

Yes it is. I'm wondering that when i look at enemy the canSee goes true. But when i turn 180 degrees it remains true even though i'm not seeing the enemy. But when i look at the enemy direction through a wall it sets it false.

 –

That's the problem: when the camera looks in another direction, OnWillRenderObject may stop being called before registering that the object isn't visible anymore.

 –

I put the canSee = false inside a void Update() and its now working. Thanks a lot! Props on you sir!

 –

Please submit this as a separate question.

 –