Sending C# commands to an OnTriggerEnter's collider object

I’m doing the Walker Boys Studio lab 2, part 33. But I’m writing all the scripts in C# to get that sweet auto-complete goodness.

The issue I’m running into occurs when the asteroid hits the player’s shield. Pretty sure they’re both set up right (a sphere with a sphere collider, IsTrigger=true, and a rigidbody).

Here’s the code that runs for the asteroid:

void OnTriggerEnter(Collider other)
{
	if (other.tag == "shield")
	{
		HitShield(other.gameObject);
		ExplodeAsteroid();
		ResetPosition();
	}
}

void HitShield(GameObject other)
{
    scriptShield localShield = (scriptShield)other.GetComponent(typeof(scriptShield));
    localShield.HitShield();
}

The error I’m getting is NullReferenceException: Object reference not set to an instance of an object, which occurs when I try to call localShield.HitShield();. Does it matter that the shield object is a prefab which is instantiated by the player prefab?

How can the object be null if I can read its tags? There’s something fundamental I’m missing, right?

Sorry forgot to say, I know you wanted to do this with ship thrusters so what you do is read the final torqueVector. Figure out which thruster is firing on the x axis and feed torqueVector.x to it, y thruster torquevector.y, z thruster torqueVector.z. Obviously you'll need to write some code to make this work but thats the logic and you should be able to follow it on your own. And it will be good practice since your getting into Newtonian stuff, this is like 101. You can do it though!

1 Answer

1

The GameObject is not null, that’s kinda impossible :wink: I guess the Script component you’re trying to access is not there. Keep in mind that “other” referes to a collider that is attached to an GameObject tagged “shield”. Your script have to be attacht to the same GameObject.

Btw. there are generic versions of GetComponent, GetComponents and GetComponentInChildren that doesn’t require you to cast the returnd type “manually”:

scriptShield localShield = other.GetComponent<scriptShield>();

If your shild-script is attached to a child of the collider you can use

scriptShield localShield = other.GetComponentInChildren<scriptShield>();

also in such cases when you’re not sure if the component is really there, you can do a check yourself:

scriptShield localShield = other.GetComponentInChildren<scriptShield>();
if (localShield != null)
{
    localShield.HitShield();
}
else
{
    Debug.LogWarning("Hit shield but no scriptShield found",this);
}

Damn, my first question and it's a "you forgot to link the script to the prefab" error. That was my mistake. Thanks, Bunny83. I'll pay more attention from now on. :-)