In trying to remove sync points from my systems, I’ve run into a point where I need to use the result of an IJobParallelForFilter as the list for a subsequent job. With other Job types I’m able to use NativeList.AsDeferredJobArray; however, that doesn’t seem to be working the same way here. My assumption is this has something to do with ScheduleAppend and ScheduleFilter only taking a NativeList instead of a NativeArray, and that for this to work properly I’d need to be able to pass the AsDeferredJobArray version to the filter job as well.
_filteredIndicesList = new NativeList<int>(Allocator.TempJob);
result = new FilterCheckedTreesJob
{
ToolEvent = toolEvent,
BrushEvent = brushEvent,
UncheckedTrees = _uncheckedTreesArray,
TreeData = GetComponentDataFromEntity<Tree>(true),
MountainPositionData = GetComponentDataFromEntity<MountainPosition>(true)
}.ScheduleAppend(_filteredIndicesList, _uncheckedTreesArray.Length, 8, result);
result = new ResizeListJob
{
Size = _filteredIndicesList.AsDeferredJobArray().Length, // returning 0
List = _treesToDemolish
}.Schedule(result);
Weirdly though, when I Complete the first job manually (for sanity checking that my filter job wasn’t just returning 0 results), the subsequent deferred array still returns 0:
_filteredIndicesList = new NativeList<int>(Allocator.TempJob);
result = new FilterCheckedTreesJob
{
ToolEvent = toolEvent,
BrushEvent = brushEvent,
UncheckedTrees = _uncheckedTreesArray,
TreeData = GetComponentDataFromEntity<Tree>(true),
MountainPositionData = GetComponentDataFromEntity<MountainPosition>(true)
}.ScheduleAppend(_filteredIndicesList, _uncheckedTreesArray.Length, 8, result);
result.Complete();
UnityEngine.Debug.Log("Hacky complete length: " + _filteredIndicesList.Length); // returns 60
result = new ResizeListJob
{
Size = _filteredIndicesList.AsDeferredJobArray().Length, // still returns 0
List = _treesToDemolish
}.Schedule(result);
Any idea what’s going on here? Is it simply not currently supported to use deferred arrays with IJobParallelForFilters? If so I suppose I can use the multi-system approach from my other thread , but I’d prefer to avoid that if possible!
In this case you no need in deferred list, because you no need length for scheduling job. Just replace Size int to just NativeList and inside your job call Length. Your jobs should be in dependency chain. In addition Deferred array works not like you expect it in this case, at schedule time it will be 0 Length, and you getting length at schedule time just as int and this int variable in your job not change at execution time.
Ah thanks for the explanation! To be honest I didn’t really understand what a deferred array was doing, I had just copied an example that worked for another case in my project and so assumed I knew enough to use them…
So, I do actually need the length for the NEXT job in the chain. My assumption would be then that I should use the newly resized List as the deferred one, but that requires me to pass it as a NativeArray to ResizeListJob, and NativeArray doesn’t have a Resize method. Allocating a new array inside the job doesn’t seem to work, I assume due to having to use Allocator.Temp?
// [BurstCompile]
struct ResizeListJob : IJob
{
[ReadOnly] public NativeList<int> SizeList;
public NativeArray<Entity> List;
public void Execute()
{
List = new NativeArray<Entity>(SizeList.Length, Allocator.Temp, NativeArrayOptions.UninitializedMemory);
// List.Resize(SizeList.Length, NativeArrayOptions.UninitializedMemory);
}
}
// [BurstCompile]
struct BuildArrayJob : IJobParallelFor
{
[ReadOnly] public NativeArray<Entity> UnfilteredEntities;
[ReadOnly] public NativeList<int> FilteredIndices;
[NativeDisableParallelForRestriction]
public NativeList<Entity> FilteredEntities;
public void Execute(int index)
{
FilteredEntities[index] = UnfilteredEntities[FilteredIndices[index]];
}
}
protected override JobHandle OnUpdate(JobHandle inputDeps)
{
// ...
_filteredIndicesList = new NativeList<int>(Allocator.TempJob);
result = new FilterCheckedTreesJob
{
ToolEvent = toolEvent,
BrushEvent = brushEvent,
UncheckedTrees = _uncheckedTreesArray,
TreeData = GetComponentDataFromEntity<Tree>(true),
MountainPositionData = GetComponentDataFromEntity<MountainPosition>(true)
}.ScheduleAppend(_filteredIndicesList, _uncheckedTreesArray.Length, 8, result);
// Build list
_treesToDemolish = new NativeList<Entity>(Allocator.TempJob);
result = new ResizeListJob
{
SizeList = _filteredIndicesList,
List = _treesToDemolish.AsDeferredJobArray()
}.Schedule(result);
// Construct the new filtered list into a usable entity array
result = new BuildArrayJob
{
UnfilteredEntities = _uncheckedTreesArray,
FilteredIndices = _filteredIndicesList,
FilteredEntities = _treesToDemolish
}.Schedule(_treesToDemolish.AsDeferredJobArray().Length, 8, result);
}
If I log SizeList.Length in ResizeListJob then I get the correct value, but if I log FilteredEntities.Length in BuildArrayJob then… it doesn’t log anything, because I assume it’s scheduling with a Length value of 0; and if I log the length of it later, outside a job after a sync point, then I get 0.
So I think the question now is “how do I use a list that I need to resize as a deferred array?”
Returning true means the index is appended to the list of indexes (if using ScheduleAppend) or the item is kept in the list (if using ScheduleFilter). Returning false means the index is not appended (ScheduleAppend), or the item is removed from the list (ScheduleFilter).