Fixed but there is still one error (see code for error) help please :)

using UnityEngine; using System.Collections; using System; //added to access the enum class

public class BaseCharacter : MonoBehaviour { private string _name; private int _level; private uint _freeExp;

private Attribute[] _primaryAttribute;
private Vital[] _vital;
private Skill[] _skill;

public void Awake () {
    _name = String.Empty;
    _level = 0;
    _freeExp = 0;

    _primaryAttribute = new Attribute[Enum.GetValues(typeof(AttributeName)).Length];
                                      ;
    _vital = new Vital[Enum.GetValues(typeof(VitalName)).Length];
    _skill = new Skill[Enum.GetValues(typeof(SkillName)).Length];

    SetUpPrimaryAttribute();
    SetUpVitals();
    SetUpSkills();
}

public string Name {
    get{ return _name; }
    set{ _name = value;}
}

public int Level {
    get{ return _level; }
    set{ _level = value;}
}

public uint FreeExp {
    get{ return _freeExp; }
    set{ _freeExp = value;}
}

public void AddExp(uint exp) {
    _freeExp += exp;

    CalculateLevel();
}

//take average of all of the players skills and assign that as the player level
public void CalculateLevel() {
}

private void SetUpPrimaryAttribute() {
    for(int cnt = 0; cnt < _primaryAttribute.Length; cnt++) {
        _primaryAttribute[cnt] = new Attribute();
    }
}

private void SetUpVitals() {
    for(int cnt = 0; cnt < _vital.Length; cnt++) {
        _vital[cnt] = new Vital();
    }
}

private void SetUpSkills() {
    for(int cnt = 0; cnt < _skill.Length; cnt++) {
        _skill[cnt] = new Skill();
    }
}

public Attribute GetPrimaryAttribute(int index) {
    return _primaryAttribute[index];
}
public Vital GetVital(int index) {
    return _vital[index];
}
public Skill GetSkill(int index) {
    return _skill[index];
}   

void AddSkillModifier(SkillName skillName, AttributeName attributeName, float value) {

Skill skill = GetSkill((int)skillName);

Attribute primary = GetPrimaryAttribute((int)attributeName);

// Below is my new error --- error CS1729: The type `ModifyingAttribute' does not contain a constructor that takes`2' arguments

ModifyingAttribute modifier = new ModifyingAttribute(primary, value); 

skill.AddModifier(modifier);

}

private void SetUpVitalModifiers() {
    //health
    GetVital((int)VitalName.Health).AddModifier(new ModifyingAttribute{attribute = GetPrimaryAttribute((int)AttributeName.Constitution), ratio = .5f});
    //energy
    GetVital((int)VitalName.Energy).AddModifier(new ModifyingAttribute{attribute = GetPrimaryAttribute((int)AttributeName.Constitution), ratio = 1});
    //mana
    GetVital((int)VitalName.Mana).AddModifier(new ModifyingAttribute{attribute = GetPrimaryAttribute((int)AttributeName.WillPower), ratio = 1});
}

public void SetUpSkillModifiers() {
// Check comments right side ->
    float m = 0.33f;
    AddSkillModifier(SkillName.Melee_Offence,  AttributeName.Might        , m);
    AddSkillModifier(SkillName.Melee_Offence,  AttributeName.Nimbleness   , m);
    AddSkillModifier(SkillName.Melee_Defence,  AttributeName.Speed        , m);
 AddSkillModifier(SkillName.Melee_Defence,  AttributeName.Constitution , m);
 AddSkillModifier(SkillName.Magic_Offence,  AttributeName.Concentration, m);
    AddSkillModifier(SkillName.Magic_Offence,  AttributeName.WillPower    , m);
    AddSkillModifier(SkillName.Magic_Defence,  AttributeName.Concentration, m);  
    AddSkillModifier(SkillName.Magic_Defence,  AttributeName.WillPower    , m); 
    AddSkillModifier(SkillName.Ranged_Offence, AttributeName.Concentration, m);
    AddSkillModifier(SkillName.Ranged_Offence, AttributeName.Speed        , m);
    AddSkillModifier(SkillName.Ranged_Defence, AttributeName.Speed        , m);
    AddSkillModifier(SkillName.Ranged_Defence, AttributeName.Nimbleness   , m);
}
public void StatUpdate () {
    for(int cnt = 0; cnt < _vital.Length; cnt++)
        _vital[cnt].Update();
    for(int cnt = 0; cnt < _skill.Length; cnt++)
        _skill[cnt].Update();
    }

}

Bash And Slash Error codes CS1729, CS1502, CS1503. What is wrong?

  • CS1729 You supplied too few or too many arguments to constructor.
  • CS1502 You supplied wrong argument type(s) for the method (or constructor).
  • CS1503 You supplied wrong argument type(s) for the method (or constructor).

It is the Under the melee offence bits all of it is errors

public void SetUpSkillModifiers() {
    //Melee Offence
    GetSkill((int)SkillName.Melee_Offence).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Might), .33f));
    GetSkill((int)SkillName.Melee_Offence).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Nimbleness), .33f));
    //Melee Defence
    GetSkill((int)SkillName.Melee_Defence).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Speed), .33f));
    GetSkill((int)SkillName.Melee_Defence).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Constitution), .33f));
    //Magic Offence
    GetSkill((int)SkillName.Magic_Offence).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Concentration), .33f));
    GetSkill((int)SkillName.Magic_Offence).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.WillPower), .33f));
    //Magic Defence
    GetSkill((int)SkillName.Melee_Defence).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Concentration), .33f));
    GetSkill((int)SkillName.Melee_Defence).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.WillPower), .33f));
    //Ranged Offence
    GetSkill((int)SkillName.Ranged_Offence).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Concentration), .33f));
    GetSkill((int)SkillName.Ranged_Offence).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Speed), .33f));
    //Ranged Defence
    GetSkill((int)SkillName.Ranged_Defence).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int)AttributeName.Speed), .33f));
    GetSkill((int)SkillName.Ranged_Defence).AddModifier(new ModifyingAttribute(GetPrimaryAttribute((int) AttributeName.Nimbleness), .33f));
}


Well, Mr. Curious, first off I'd recommend that you break off your insanely long statements into something more manageable, and maybe make a method so you don't have to repeat yourself.

AddSkillModifier(SkillName.Melee_Offence, AttributeName.Might, .33f);

And then create method

void AddSkillModifier(SkillName skillName, AttributeName attributeName, float value) {
    // This seems ok.
    Skill skill = GetSkill((int)skillName);

    // This seems to return a System.Attribute, is this intended?
    Attribute primary = GetPrimaryAttribute((int)attributeName);

    // This probably cause CS1729 since it invokes a constructor. 
    // Check your constructor for that type.
    // This could perhaps cause CS1502 and CS1503. 
    // Maybe you're passing System.Attribute where you expected something else?
    ModifyingAttribute modifier = new ModifyingAttribute(primary, value); 

    // This could perhaps cause CS1502 and CS1503.
    skill.AddModifier(modifier);
}

Note that you have imported System namespace. It contains an Attribute class. Perhaps you are having some ambiguity in your code because of this?

With this new method your code should be clearer:

public void SetUpSkillModifiers() {
    // Check comments right side ->
    float m = 0.33f;
    AddSkillModifier(SkillName.Melee_Offence,  AttributeName.Might        , m);
    AddSkillModifier(SkillName.Melee_Offence,  AttributeName.Nimbleness   , m);
    AddSkillModifier(SkillName.Melee_Defence,  AttributeName.Speed        , m);
    AddSkillModifier(SkillName.Melee_Defence,  AttributeName.Constitution , m);
    AddSkillModifier(SkillName.Magic_Offence,  AttributeName.Concentration, m);
    AddSkillModifier(SkillName.Magic_Offence,  AttributeName.WillPower    , m);
    AddSkillModifier(SkillName.Melee_Defence,  AttributeName.Concentration, m); // Melee? Bug?
    AddSkillModifier(SkillName.Melee_Defence,  AttributeName.WillPower    , m); // Melee? Bug?
    AddSkillModifier(SkillName.Ranged_Offence, AttributeName.Concentration, m);
    AddSkillModifier(SkillName.Ranged_Offence, AttributeName.Speed        , m);
    AddSkillModifier(SkillName.Ranged_Defence, AttributeName.Speed        , m);
    AddSkillModifier(SkillName.Ranged_Defence, AttributeName.Nimbleness   , m);
}