Function not waiting

[C3k456]

I’m trying to get this enemy function to wait for the death animation to play before destroying the game object, otherwise it gets destroyed before the animation finishes. I’ve looked online and it seems that I’m doing everything right, but it just won’t wait.

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class EnemyHealth : MonoBehaviour
{
    [SerializeField] float health, maxHealth = 3f; // This creates two variables, health and max health. SerializeField is needed so that these variables can stay private but be accessible within the Unity editor

    public Animator anim;

    private void Start()
    {
        health = maxHealth;
    }

    private IEnumerator Wait()
    {
        yield return new WaitForSeconds(5);
    }

    public void TakeDamage(float damageAmount) // Method that takes in a damage amount as a float and inflicts it upon the enemy
    {
        health -= damageAmount; // The damage amount is taken away from the current health

        if (health <= 0) // If the enemy has not more health left once it has taken damage:
        {
            anim.SetTrigger("Death");
            StartCoroutine (Wait());
            Debug.Log("Waiting");
            Destroy(gameObject); // Then it dies
        }
    }

}

[pertholdth]

thats not how it works, you have to do something like this

 private IEnumerator WaitAndDie()
    {
        yield return new WaitForSeconds(5);
 Destroy(gameObject); // Then it dies
    }

StartCoroutine (WaitAndDie());

[MelvMay]

Please don’t use the 2D tag unless you’re asking about 2D features. This should be tagged “Scripting”.

I’ll do that for you.

Thanks.

[C3k456]

This worked, thank you!
I’m sure this was a big beginner mistake, but I just simply didn’t have the time to do in depth research about coroutines.

[Kurt-Dekker]

@C3k456

I just simply didn’t have the time to do in depth research about coroutines.

I would recommend against using things you don’t have the time to understand.

Coroutines in a nutshell:

Proper way to stop coroutine?

Coroutines are an IEnumerator object. They have their own internal state. It’s different from just calling InvokeRepeating(), which would restart a fresh function call each time. Here is ALL you need to know about coroutines in Unity: they are an IEnumerator, also known in some languages as a Generator. It is an object with a .MoveNext() method on it that “yields” the next thing with each subsequent call. That is what you create by calling an IEnumerator: you create the object, you do NOTHIN…

Destroying the object then restarting the scene

Hey Epoch, here’s how it goes down. A coroutine is just an IEnumerator object, and you make one by just calling a coroutine. When you do that, nothing happens. It’s like a water pump that needs to have its crank pumped, but nobody is pumping it so it sits there and does nothing. In Unity there’s a special agreement: if you hand that IEnumerator object into StartCoroutine(), which is a method belonging to the object where that StartCoroutine() call is located, what Unity does is starts “pumpin…

Splitting up larger tasks in coroutines:

Best Way to Split a Long-Running Function So it's Non-Blocking?

Technically, yeah, there’s always a way. But in practice, in the general sense it can get really hairy. Also, in the particular case of adding lots of GameObjects, I know they’re not linear: last I checked, adding 1000 GameObjects is WAY more than 10x slower than adding 100 Gameobjects, I presume due to inefficiencies in newly-added stuff, not sure/ No way to tell with a closed-source engine like Unity. Trying to tie into system timers and judge how long things have taken so far will get you …

Coroutines are NOT always an appropriate solution: know when to use them!

“Why not simply stop having so many coroutines ffs.” - orionsyndrome on Unity3D forums

Things to check before starting a coroutine?

The main thing to check before calling / making a coroutine is to ask yourself, “Does this even need to be a coroutine?” Generally, if your design requires you to call StopCoroutine(), then don’t make it a coroutine. If you just need something to happen a bit later, this is a more-robust approach: https://gist.github.com/kurtdekker/0da9a9721c15bd3af1d2ced0a367e24e If you’re flipping from one value to another, such as fading in, fading out, changing speeds slowly, etc., coroutines are an AW…

Heartbeat courutine fx

Again I would not reach for coroutines here. The reason: you can go below the critical health, then go up, then go back down, and every single point in there is a chance to screw up how many coroutines are actually running. Coroutines are great but they are the wrong solution for this problem. Instead, make a heartbeat script and have a variable to count if it is time yet: private float heartBeatYet; In your Update() function, calculate the desired rate of heartbeat based on health: float …

Our very own Bunny83 has also provided a Coroutine Crash Course:

Coroutines IEnumerator not working as expected

I’m kinda suprised that until now nobody has asked a question like this. Even though I have explained what a coroutine actually is several times in other questions it just shows that there is still quite a misunderstanding what a coroutine actually is. Lets just step back for a moment. Unity implements coroutines by utilizing a C# feature called “iterator blocks” or iterator methods (which are more generally known as Generator methods). C# ships with two relevant interfaces (IEnu…

And another overview by Anders Malmgren:

I'm addicted to using Coroutines. Any alternatives?

You need to understand the basics of what the Unity coroutine system is based on. Its not magic, its based on the fundamental basics of C# 3.0 which introduced the iterator pattern as part of their Linq feature. Any method that returns IEnumerator or IEnumerator<T> or IEnumerable/<T> can be iterated upon. This is actually a very easy concept. The IEnumerator interface as follows public interface IEnumerator { bool MoveNext(); object Current { get; } void Reset(); } Its…

[C3k456]

Thank you so much for the explanation!
The reason that I’m not doing research into coroutines is because this is a school project where I predict that I will only use this feature once, and I only have a few days to finish basically the entire thing cos I’m an idiot
But I will definitely look over this again to make sure I understand it fully once I have the time, so I appreciate this a bunch!