I want to make it so that when two keys are pressed, my character moves with certain vectors, but it doesn’t seem to work except for when I want the character to move Right and Forward. I used the same code for each direction, so what gives?
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
public class Movement : MonoBehaviour {
// Keys Are Held
private bool wIsHeld = false;
private bool aIsHeld = false;
private bool sIsHeld = false;
private bool dIsHeld = false;
//Random Stuffs
private Rigidbody rb;
public float moveSpeed = 0.2f;
//Vectors
private Vector3 moveNorth = new Vector3 (0f, 0f, 1f);
private Vector3 moveNorthWest = new Vector3 (-1f, 0f, 1f);
private Vector3 moveWest = new Vector3 (-1f, 0f, 0f);
private Vector3 moveSouthWest = new Vector3 (-1f, 0f, -1f);
private Vector3 moveSouth = new Vector3 (0f, 0f, -1f);
private Vector3 moveSouthEast = new Vector3 (1f, 0f, -1f);
private Vector3 moveEast = new Vector3 (1f, 0f, 0f);
private Vector3 moveNorthEast = new Vector3 (1f, 0f, 1f);
// Use this for initialization
void Start () {
rb = GetComponent<Rigidbody> ();
}
// Update is called once per frame
void Update () {
//W Is Held
if (Input.GetKey ("w")) {
wIsHeld = true;
}
if (Input.GetKeyUp ("w")) {
wIsHeld = false;
}
//A Is Held
if (Input.GetKey ("a")) {
aIsHeld = true;
}
if (Input.GetKeyUp ("a")) {
aIsHeld = false;
}
//S Is Held
if (Input.GetKey ("s")) {
sIsHeld = true;
}
if (Input.GetKeyUp ("s")) {
sIsHeld = false;
}
//D Is Held
if (Input.GetKey ("d")) {
dIsHeld = true;
}
if (Input.GetKeyUp ("d")) {
dIsHeld = false;
}
//Movement Forward
if (wIsHeld == true) {
rb.MovePosition (transform.position + moveNorth * moveSpeed);
}
//Movement Forward + Left
if ( wIsHeld == true && aIsHeld == true || aIsHeld == true && wIsHeld == true) {
rb.MovePosition (transform.position + moveNorthWest * moveSpeed);
}
//Movement Left
if (aIsHeld == true) {
rb.MovePosition (transform.position + moveWest * moveSpeed);
}
//Movement Left + Back
if (aIsHeld == true && sIsHeld == true || sIsHeld == true && aIsHeld == true) {
rb.MovePosition (transform.position + moveSouthWest * moveSpeed);
}
//Movement Back
if (sIsHeld == true) {
rb.MovePosition (transform.position + moveSouth * moveSpeed);
}
//Move Back + Right
if (sIsHeld == true && dIsHeld == true || dIsHeld == true && sIsHeld == true) {
rb.MovePosition (transform.position + moveSouthEast * moveSpeed);
}
//Move Right
if (dIsHeld == true){
rb.MovePosition (transform.position + moveEast * moveSpeed);
}
//Move Right + Forward
if ( wIsHeld == true && dIsHeld == true || dIsHeld == true && wIsHeld == true) {
rb.MovePosition (transform.position + moveNorthEast * moveSpeed);
}
}
}
You are thinking way to complex imo. Here are two solutions in one, you can switch between them with the “useAxis” bool.
The useAxis solution uses the GetAxis(name) function, you can control them in the InputManager. that is also where you can reduce the drag that is introduced by the default settings (the Gravity setting). The advantage is, much shorter code, you can configure the axis in the inspector, don’t go for specific keys and it is rebindable by the player.
The !useAxis, is basically what you are doing but WAY shorter. I’m just adding up the vector for every button and shove it normalized into movePosition.
using UnityEngine;
public class Movement : MonoBehaviour
{
private Rigidbody rb;
public float moveSpeed = 1f;
public bool useAxis;
void Start ()
{
rb = GetComponent<Rigidbody>();
}
void Update () {
Vector3 direction = Vector3.zero;
if (useAxis)
{
direction.x = Input.GetAxis("Horizontal");
direction.y = Input.GetAxis("Vertical");
}
else
{
if (Input.GetKey(KeyCode.W))
{
direction += Vector3.up;
}
if (Input.GetKey(KeyCode.A))
{
direction += Vector3.left;
}
if (Input.GetKey(KeyCode.S))
{
direction += Vector3.down;
}
if (Input.GetKey(KeyCode.D))
{
direction += Vector3.right;
}
}
if (direction != Vector3.zero)
{
rb.MovePosition(transform.position + direction.normalized * moveSpeed * Time.deltaTime);
}
}
}
When it comes to complicated scripts it’s best to break everything down into smaller functions so everything becomes easier to read and follow.
Personally i’m also a fan of hard coding controls but this can be updated to use the Input functions such as Input.OnButtonDown(“Jump”) and so on.
This script should allow the player to move in all 4 directions as well as move on an angle if they are holding down W+D for example.
If you want to check special cases where the user is moving on an angle. Then you can nest some if statements in the MovePlayer method and check for more than 1 key is pressed.
using UnityEngine;
using System.Collections;
using System.Collections.Generic;
public class Movement : MonoBehaviour
{
public string MoveForwardButton = "w";
public string MoveBackButton = "s";
public string MoveLeftButton = "a";
public string MoveRightButton = "d";
private List<string> PressedButtons = new List<string>();
void Update()
{
CheckButton(MoveForwardButton);
CheckButton(MoveBackButton);
CheckButton(MoveLeftButton);
CheckButton(MoveRightButton);
MovePlayer();
}
private void CheckButton(string buttonKey)
{
if (Input.GetButtonDown(buttonKey))
{
PressedButtons.Add(buttonKey);
}
else if (Input.GetButtonUp(buttonKey))
{
PressedButtons.Remove(buttonKey);
}
}
private void MovePlayer()
{
Vector2 moveDirection = Vector2.zero;
if (PressedButtons.Contains(MoveForwardButton))
{
moveDirection.y += 1;
}
else if (PressedButtons.Contains(MoveBackButton))
{
moveDirection.y -= 1;
}
else if (PressedButtons.Contains(MoveLeftButton))
{
moveDirection.x -= 1;
}
if (PressedButtons.Contains(MoveRightButton))
{
moveDirection.x += 1;
}
}
}