Problem with AI that flee away

Unity Engine
1

Currently I’m working on AI enemies in my project and I ran into a problem that I can’t solve,
In the following script, I made the AI run after the player if he see’s him, or he gets hit by the player,

problem is that the enemy runs away from me, I run towards the enemy and he flees back, the AI enemy can’t be in a distance less then 12 units from me. dunno what I made wrong, but it’s kinda weird.

    void Update () {

        rb.velocity = Vector3.ClampMagnitude(rb.velocity, maxSpeed);     
        float Distance = Vector2.Distance(transform.position, player.position);

        HealthText();

        if (!Health.isDead() && (HaveSeenPlayer() || gotHit))
        {
            if (Distance > 4f)
            {
                MoveTowardsPlayer();
            }
            else
                Attack();
        }
        else
            EnemyCalmState();
    }

    bool HaveSeenPlayer()
    {
        Vector2 newPos2D = new Vector2(transform.position.x + Offset(), transform.position.y);
        RaycastHit2D hit = Physics2D.Raycast(newPos2D, Direction(), 4);

        if (hit.collider != null && hit.transform.name == "Player")
            return true;

        return false;
  
    }
2

we need to see the MoveTowardsPlayer() function, or you script is reverting to the EnemyCalmState, and that might be move away from player

my code notes

        if (!Health.isDead() && (HaveSeenPlayer() || gotHit))
        {
            if (Distance > 4f) // if the player is to far away then move closer
            {
                MoveTowardsPlayer(); // move closer
            }else
            {
                Attack(); // i'm close enough so attach the player
            }
        }else //i'm dead, or i have not seen the player or have not gotten hit by the player
        {
            EnemyCalmState();  // do the calm state, ie, idle, patrol....
        }
3 
   void MoveTowardsPlayer()
    {
            rb.AddForce(player.position * enemyWalkSpeed);
            ChangeEnemyDirection();

           EnemyAnimationController.Walk();      
    }

    void EnemyCalmState()
    {
        Vector2 newPosToWalk = new Vector2(newXPos, transform.position.y); // Vector for the new position

        if (!newPositionOnce) {
            newXPos = Random.Range(SpawnedPosOnXaxis - 5, SpawnedPosOnXaxis + 5);
            newPositionOnce = true;
        } // A random point that the enemy can go to

        if ((int)transform.position.x != (int)newXPos) // if the enemy hasn't reached the new position yet
        {
            rb.AddForce((newPosToWalk - (Vector2)transform.position) * enemyWalkSpeed);

            EnemyAnimationController.Walk();
            ChangeEnemyDirection(newXPos);
        }
        else // if the enemy has reached the new position, it will rest 2 seconds, and then timer will reset, and also one time bool will renabled for a new X position.
        {
            EnemyAnimationController.Idle();
            Timer += Time.deltaTime;

            if (Timer > 2)
            {
                newPositionOnce = false;
                Timer = 0;
            }
        }

    }
4

my 2 cents while someone else is helping you:
If you need only compare a distance as < or > , instead of Distance, you can use (target.position - transform.position).sqrMagnitude
then check if that value is less than or greater than your checkedDistance * checkedDistance

5

I lack of knowledge in Math/Physics, should I always substract 2 vectors in order to get the new position vector?

    void MoveTowardsPlayer()
    {
        rb.AddForce((player.position - transform.position) * enemyWalkSpeed);
        ChangeEnemyDirection();

         EnemyAnimationController.Walk();    
    }
6

I was referring to this more specifically:

float Distance = Vector2.Distance(transform.position, player.position);

which could be:

float Distance = (transform.position - player.position).sqrMagnitude;
// later, if you wanted to check > 4
if(Distance > (4 * 4)) { // etc

This avoids a square root calculation, if you don’t need the precise distance. It’s just a performance tweak.