score counter not working :(

Unity Engine
,
1

i have a score counter for that whenever the enemy is hit the score should go up by one
im using this guide: Building a Score System with UI Elements in Unity | by Jared Amlin | Level Up Coding (even though the guide is for 2d I’ve used it before in 3d and its worked perfectly, idk why its not working now)

no idea why its not working
maybe be related to uIManager, but in previous projects where I’ve used this code it still works

any help appreciated
thanks :slight_smile:

script attached to enemy:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.UI;

public class EnemyScore : MonoBehaviour
{
    private ScoreManager uIManager;

    private void OnCollisionEnter(Collision collision)
    {
        // checking if the UI manager is null so that the score can be updated
        if (uIManager != null)
        {
            // shows that the score iss being updated by one point only
            uIManager.UpdateScore(1);
        } 
    }

    void Start()
    {
        // acessing the game score in the UI
        uIManager = GameObject.Find("Canvas").GetComponent<ScoreManager>();
    }
}

script attached to canvas:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using TMPro;
using UnityEngine.UI;

public class ScoreManager : MonoBehaviour
{
    [SerializeField] private int score;
    [SerializeField] TMP_Text scoreText;

    void Start()
    {
        score = 0;
    }

    public void UpdateScore(int points)
    {
        score += points;

        scoreText.text = "SCORE: " + score.ToString();
    }

}

8671368--1168173--Screenshot 2022-12-18 at 17.17.55.jpg
8671368--1168173--Screenshot 2022-12-18 at 17.17.55.jpg1278×782 137 KB

8671368--1168176--Screenshot 2022-12-18 at 17.18.18.png
8671368--1168176--Screenshot 2022-12-18 at 17.18.18.png1032×786 110 KB

2

Your code seems to be working fine. Have you tried restarting Unity?

3

Except of course that it’s not. Is any of it even running? Find out!

Photographs of code are not a thing. If you post a code snippet, ALWAYS USE CODE TAGS:

How to use code tags: https://discussions.unity.com/t/481379

Remember the first rule of GameObject.Find():

Do not use GameObject.Find();

More information: https://starmanta.gitbooks.io/unitytipsredux/content/first-question.html

More information: https://discussions.unity.com/t/899843/12

Beyond that, here is how to get started debugging:

You must find a way to get the information you need in order to reason about what the problem is.

Once you understand what the problem is, you may begin to reason about a solution to the problem.

What is often happening in these cases is one of the following:

- the code you think is executing is not actually executing at all

  • the code is executing far EARLIER or LATER than you think
  • the code is executing far LESS OFTEN than you think
  • the code is executing far MORE OFTEN than you think
  • the code is executing on another GameObject than you think it is
    - you’re getting an error or warning and you haven’t noticed it in the console window

To help gain more insight into your problem, I recommend liberally sprinkling Debug.Log() statements through your code to display information in realtime.

Doing this should help you answer these types of questions:

  • is this code even running? which parts are running? how often does it run? what order does it run in?
  • what are the values of the variables involved? Are they initialized? Are the values reasonable?
  • are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

Knowing this information will help you reason about the behavior you are seeing.

You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as Debug.Log("Problem!",this);

If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

You could also just display various important quantities in UI Text elements to watch them change as you play the game.

If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer or iOS: https://discussions.unity.com/t/700551 or this answer for Android: https://discussions.unity.com/t/699654

If you are working in VR, it might be useful to make your on onscreen log output, or integrate one from the asset store, so you can see what is happening as you operate your software.

Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

Here’s an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

https://discussions.unity.com/t/839300/3

When in doubt, print it out!™

Note: the print() function is an alias for Debug.Log() provided by the MonoBehaviour class.

If you’re just getting a nullref, then go fix it.

How to fix a NullReferenceException error

https://forum.unity.com/threads/how-to-fix-a-nullreferenceexception-error.1230297/

Three steps to success:

  • Identify what is null ← any other action taken before this step is WASTED TIME
  • Identify why it is null
  • Fix that
4

wow thanks !! ill definitely switch to code tags right away
and ill keep testing all my code :slight_smile:

5

taking in what you’ve said and using “Debug.Log” it seems that in the enemy score script where i have oncollsionenter that there is no collision between the enemy and the raycast
however in a seperate script where i have the enemy’s health i know that the collision works bc of a debug message and that the enemy is destroyed after 10 hits

would there be interference with the script as i know my raycast works ?
would there be an issue if i have three scripts attached to the enemy ?

thanks again :slight_smile:

6

UPDATE:

it now works !!!
turns out the solution was to have the entire enemy score script into my enemy health script
i believe the main issue was the ‘oncollisionenter’ as my enemy health script has a different event function

but thanks again for all your help
i will keep your advice in mind when moving forward and i will continue to improve my skills

thank you :slight_smile:

7

You’re welcome!

It’s all about isolating exactly what is failing: see how you isolated that the collision wasn’t happening? That meant you no longer wasted time anywhere else until it worked… and there you go, that was the only problem.

Sometimes there are series of problems and you have to solve them one at a time, which is why it’s always best not to write or make too much before verifying it works.