[SOLVED] Function Call ArguementOutOfRangeException This is killing me!

Unity Engine
1

Hello I’m having some trouble with calling a function with my code, I am trying to create an endless runner type game so as my player moves I need to create Objects, on awake I instantiate 20 of my prefab and add them them to an List, this List is for the Objects I have not used yet, on start I call my Spawn function 18 times which transforms my Objects to where they need to be and then adds them to another List whilst removing themselves from their current List, this List contains the Objects I have already used and then I grab the first element from the used List and add it to the back of my first List ready to be used again, I am trying to object pool.

The idea of the List’s is for when I spawn a “turn point” I add a prefab to each area of access and each area has it’s own List and I add a Object from that area to the List so when my character turns a corner I have every Object in front of him belonging to a List, depending on the direction my character turns will determine which List I will take an object out of until the List is empty and then a different List will follow and then finally the List for the direction we turned in, this is all to stop removing the Object my character is currently on a way of remembering you could say, this is not complete for turning corners and such at the moment it just creates a straight endless path in front of the character (which is what I want for the moment) but I can’t even get that to work and I have literally done this a few times before I must be losing it, I created a script like this a while back I still have it and it works I just decided to write a new one differently from scratch to see if I could improve it overall.

My problem is that my start function calls Spawn 18 times without fail… works like a charm so I have 18 Objects in front of my character, every time he leaves an Object I want to call Spawn which then adds the Object we just left to the end of the path, I use OnTriggerExit to call Spawn and everytime I call Spawn from anywhere in my player script I get:

“ArgumentOutOfRangeException: Argument is out of range.
Parameter name: index
System.Collections.Generic.List`1[UnityEngine.GameObject].get_Item (Int32 index) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Collections.Generic/List.cs:633)
GameManager.Spawn () (at Assets/Scripts/GameManager.cs:103)
Player.OnTriggerExit (UnityEngine.Collider other) (at Assets/Scripts/Player.cs:163)”

But if I call Spawn from within it’s own script with some input in Update everything works!
If I call Spawn from the player script with anything it wont work, I made a test function in the manager script with a debug.log and called that from my player script and that works it’s only my Spawn function!

I’m not well experienced i’m still trying to get to grips with everything, I have been learning on & off for about 2-3 years, If some one could help me with this I would be so thankful.!!

My manager Script:

using System.Collections;
using System.Collections.Generic;
using System.Linq;
using UnityEngine;

public class GameManager : MonoBehaviour {

    public Player player;

    public GameObject[] Prefabs;
    public GameObject currentPrefab1, currentPrefab2, currentPrefab3;
    public List <GameObject> forward, left, right, turnPoints;
    public int toSpawn = 2, nextSpawn = 1, lastSpawn = 0, randomTP = 0, randomRot = 0, pooledAmount = 20;
    public List <int> list = new List <int>();
//    bool restarting;
    void Awake () {
        for (int i = 0; i < pooledAmount; i++) {
            GameObject hallSpawn1 = (GameObject)Instantiate (Prefabs [0]);
            forward.Add (hallSpawn1);
            hallSpawn1.name = ("Hallway " + i);
        }
        GameObject turnpointSpawn1 = (GameObject)Instantiate (Prefabs [1]);
        turnpointSpawn1.SetActive (false);
        turnPoints.Add (turnpointSpawn1);
    }
    void Start () {
        forward [0].transform.position = Vector3.zero;
        currentPrefab1 = forward [0];
        for (int i = 0; i < 19; i++) {
            forward [i +1].transform.position = currentPrefab1.transform.GetChild (0).transform.position;
            forward [i +1].transform.eulerAngles = currentPrefab1.transform.eulerAngles;
            currentPrefab1 = forward [i +1];
        }       
    }
    public void Spawn () {
        if (list.Any()) {
            toSpawn = list [0];
            list.Remove (list [0]);
        }
        switch (toSpawn) {
        case 0:
            turnPoints [0].transform.position = currentPrefab1.transform.GetChild (0).transform.position;
            turnPoints [0].transform.eulerAngles = currentPrefab1.transform.eulerAngles;
            player.newPos = turnPoints [0].transform.GetChild (0).position;
            currentPrefab1 = turnPoints [randomTP];
            currentPrefab2 = turnPoints [randomTP].transform.GetChild (0).gameObject;
            currentPrefab3 = turnPoints [randomTP].transform.GetChild (1).gameObject;
            turnPoints [randomTP].SetActive (true);
            SetRot ();
            break;
        case 1:
            forward [0].transform.position = currentPrefab2.transform.GetChild (0).position;
            forward [0].transform.eulerAngles = currentPrefab2.transform.GetChild (0).eulerAngles;
            currentPrefab2 = forward [0];
            left.Add (forward [0]);
            forward.Remove (forward [0]);
            break;
        case 2:
            forward [0].transform.position = currentPrefab1.transform.GetChild (0).transform.position;
            forward [0].transform.eulerAngles = currentPrefab1.transform.eulerAngles;
            currentPrefab1 = forward [0];
            forward.Add (forward [0]);
            forward.Remove (forward [0]);
            break;
        case 3:
            forward [0].transform.position = currentPrefab3.transform.GetChild (0).position;
            forward [0].transform.eulerAngles = currentPrefab3.transform.GetChild (0).eulerAngles;
            currentPrefab3 = forward [0];
            right.Add (forward [0]);
            forward.Remove (forward [0]);
            break;
        }
    }
    void SetRot () {
        randomRot = 0;//Random.Range (0, 6);
        switch (randomRot) {
        case 0:
            turnPoints [0].transform.GetChild (4).gameObject.SetActive (true);
            turnPoints [0].transform.GetChild (5).gameObject.SetActive (true);
            turnPoints [0].transform.GetChild (4).localEulerAngles = new Vector3 (180, 0, 0);
            turnPoints [0].transform.GetChild (5).localEulerAngles = new Vector3 (180, 270, 0);
            toSpawn = 1;
            break;
        case 1:
            turnPoints [0].transform.GetChild (4).gameObject.SetActive (true);
            turnPoints [0].transform.GetChild (5).gameObject.SetActive (true);
            turnPoints [0].transform.GetChild (4).localEulerAngles = new Vector3 (180, 180, 0);
            turnPoints [0].transform.GetChild (5).localEulerAngles = new Vector3 (180, 270, 0);
            toSpawn = 3;
            break;
        case 2:
            turnPoints [0].transform.GetChild (4).gameObject.SetActive (true);
            turnPoints [0].transform.GetChild (4).localEulerAngles = new Vector3 (180, 270, 0);
            turnPoints [0].transform.GetChild (5).gameObject.SetActive (false);
            list = new List <int> {1 ,3, 1, 3, 1, 3, 1, 3, 1, 3, 1 ,3, 1, 3, 1, 3, 1, 3, 1, 3};
            break;
        case 3:
            turnPoints [0].transform.GetChild (4).gameObject.SetActive (true);
            turnPoints [0].transform.GetChild (4).localEulerAngles = new Vector3 (180, 0, 0);
            turnPoints [0].transform.GetChild (5).gameObject.SetActive (false);
            list = new List <int> {1, 2, 1, 2, 1, 2, 1, 2, 1, 2, 1, 2, 1, 2, 1, 2, 1, 2, 1, 2};
            break;
        case 4:
            turnPoints [0].transform.GetChild (4).gameObject.SetActive (true);
            turnPoints [0].transform.GetChild (4).localEulerAngles = new Vector3 (180, 180, 0);
            turnPoints [0].transform.GetChild (5).gameObject.SetActive (false);
            list = new List <int> {2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3};
            break;
        case 5:
            turnPoints [0].transform.GetChild (4).gameObject.SetActive (false);
            turnPoints [0].transform.GetChild (5).gameObject.SetActive (false);
            list = new List <int> {1, 2, 3, 1, 2, 3, 1, 2, 3, 1, 2, 3, 1, 2, 3, 1, 2, 3, 1 , 3};
            break;
        }
    }

    public void SpawnAll () {
        if (player.rotDir == 2) {
            do {
                if (left.Any ()) {
                    forward.Add (left [0]);
                    left.Remove (left [0]);
                } else {
                    for (int i = 0; i < forward.Count; i++) {
                        Spawn ();
                    }
                    forward.InsertRange (0, right);
                    right.Clear ();
                }
            } while (right.Any ());
        } else if (player.rotDir == 1) {
            do {
                if (right.Any ()) {
                    forward.Add (right [0]);
                    right.Remove (right [0]);
                } else {
                    for (int i = 0; i < forward.Count; i++) {
                        Spawn ();
                    }
                    forward.InsertRange(0, left);
                    left.Clear ();
                }
            } while (left.Any ());
        } else {
                while (left.Any ()) {
                    forward.Insert (0, left [0]);
                    left.Remove (left [0]);
                    Spawn ();
            }
                while (right.Any ()) {
                    forward.Insert (0, right [0]);
                    right.Remove (right [0]);
                    Spawn ();
            }
        }
    }
}

My player Script:

using System.Collections;
using UnityEngine;

public class Player : MonoBehaviour {
    public float runSpeed = 1;
    public float dodgeSpeed = 1;
    public float jumpStr = 20;
    public float gravity = 20;
    public float laneNumber = 2;
    public float rotSpeed = 90;
    public float degTurned, degToTurn, rotDir;
    public bool stopMoving, canRot, willRot, isDead, stopRunning, hasJumped;
    public GameManager manager;
    public Vector3 newLanePos, newPos;
    private Vector3 jumpDir = Vector3.zero;
    private Animator anim;
    private CharacterController controller;
    void Start () {
        anim = gameObject.GetComponentInChildren<Animator>();
        controller = gameObject.GetComponentInChildren<CharacterController>();
    }
    void Update () {
        if ((!isDead) && (!stopRunning)) {
            transform.parent.Translate (0, 0, runSpeed);
        }
        if (Input.GetKeyUp (KeyCode.LeftArrow) && (!stopMoving)) {
            if (canRot) {
                willRot = true;
                canRot = false;
                rotDir = 1;
            } else if (laneNumber > 1) {
                laneNumber -= 1;
                stopMoving = true;
                StartCoroutine (StopMovement ());
            }
        }
        if (Input.GetKeyUp (KeyCode.RightArrow) && (!stopMoving)) {
            if (canRot) {
                willRot = true;
                canRot = false;
                rotDir = 2;
            } else if (laneNumber < 3) {
                laneNumber += 1;
                stopMoving = true;
                StartCoroutine (StopMovement ());
            }
        }
        if (degToTurn > degTurned) {
            if (rotDir == 1) {
                transform.parent.Rotate (0, -rotSpeed * Time.deltaTime, 0);
            } else if (rotDir == 2) {
                transform.parent.Rotate (0, rotSpeed * Time.deltaTime, 0);
            }
            degTurned += rotSpeed * Time.deltaTime;
            if (degTurned >= 90)
                rotClear ();
        }
        if (stopMoving) { 
            if (laneNumber == 1) {
                newLanePos = new Vector3 (-5, transform.localPosition.y, transform.localPosition.z);
                transform.localPosition = Vector3.MoveTowards (transform.localPosition, newLanePos, dodgeSpeed); 
            } else if (laneNumber == 2) {
                newLanePos = new Vector3 (0, transform.localPosition.y, transform.localPosition.z);
                transform.localPosition = Vector3.MoveTowards (transform.localPosition, newLanePos, dodgeSpeed);
            } else if (laneNumber == 3) {
                newLanePos = new Vector3 (5, transform.localPosition.y, transform.localPosition.z);
                transform.localPosition = Vector3.MoveTowards (transform.localPosition, newLanePos, dodgeSpeed);
            }
        }
        if (Input.GetKeyUp (KeyCode.DownArrow) && (!stopMoving) && (!hasJumped) && (controller.isGrounded)) {
            anim.SetInteger ("animPar", 2);
            stopMoving = true;
            controller.height = 2;
            controller.center = new Vector3 (0, 2, 0);
            StartCoroutine (StopMovement ());
        } else if (Input.GetKeyUp (KeyCode.UpArrow) && (!stopMoving) && (!hasJumped)) {
            anim.SetInteger ("animPar", 1);
            stopMoving = true;
            jumpDir.y = jumpStr;
            StartCoroutine (Jump ());
        }
        if ((controller.isGrounded) && (hasJumped)) {
            hasJumped = false;
            stopMoving = false;
            anim.SetInteger ("animPar", 0);
        }
        jumpDir.y -= gravity * Time.deltaTime;
        controller.Move (jumpDir * Time.deltaTime);
    }
    IEnumerator StopMovement() {
        yield return new WaitForSeconds (0.5f);
        stopMoving = false;
        anim.SetInteger ("animPar", 0);
        controller.height = 8;
        controller.center = new Vector3 (0, 4, 0);
    }
    IEnumerator Jump () {
        yield return new WaitForSeconds (0.5f);
        hasJumped = true;
    }
    void OnTriggerEnter (Collider other) {
        if (other.gameObject.CompareTag ("TurnPointDec")) {
            canRot = true;
        } else if ((other.gameObject.CompareTag ("TurnPointTurn")) && (willRot)) {
            stopRunning = true;
            stopMoving = true;
            degToTurn = 90;
            laneNumber = 2;
            willRot = false;
            if (rotDir == 1) {
                manager.currentPrefab1 = manager.currentPrefab2;
            } else {
                manager.currentPrefab1 = manager.currentPrefab3;
            }
        }
    }
    void OnTriggerExit (Collider other) {

        if (other.gameObject.CompareTag ("TurnPointDec")) {
            canRot = false;
        } else if (other.gameObject.CompareTag ("Hallway")) {
            manager.Spawn ();
        } else if (other.gameObject.CompareTag ("TurnPoint")) {
            other.gameObject.SetActive (false);
            manager.toSpawn = 2;
            manager.SpawnAll ();
            rotDir = 0;
        }
    }
    void OnCollisionEnter (Collision other) {

        if (other.gameObject.CompareTag ("KillPoint")) {
            isDead = true;
            anim.SetInteger ("animPar", 3);
        }
    }
    void rotClear () {
        degToTurn = 0;
        degTurned = 0;
        stopRunning = false;
        stopMoving = false;
        Vector3 roundToNearest90 = transform.eulerAngles;
        roundToNearest90.y = Mathf.Round (roundToNearest90.y / 90) * 90;
        transform.parent.eulerAngles = roundToNearest90;
        transform.parent.position = newPos;
    }
}
2

In the last line of Start in your manager script, you remove index 0 of toBeUsed. On line 103 you then try to set the transform.postion of toBeUsed[0], even though there is nothing at index 0. That’s my best guess at least.

Before you try to reference an object in a list by index number, you should first be sure that index number exists. I’d add a check before your code at line 103 to check what the length of the toBeUsed list is.

Also it is really confusing when reading your explanation when you continually are using the term “array” when you sometimes mean “list” and “prefab” when you sometimes mean “GameObject”. Arrays and Lists aren’t the same thing. A prefab is something you instantiate to create a GameObject. Once the object exists in your scene, even if hidden in an object pool, those aren’t prefabs. For example, your character can’t have 18 prefabs in front of him. That makes no sense, because a prefab is specifically something not actually in your scene. That’s like saying you have a vehicle blueprint in your garage, when you mean you have a car in your garage.

1 Like
3

when I run the script everything spawns in and without calling anything I am left with 19 objects in the toBeUsed array and 1 in used array, I have made *sure that something occupies toBeUsed [0], the function calls fine from it’s own script every single time i call it but it wont call from my player script.

4

Without taking a closer look at everything that touches the lists, let’s assume they’re initialized correctly and not messed up anywhere (there’re some strange parts in your code though).

Since you say you everything works until you try to call the Spawn method from the player, you should make sure that you’ve linked the correct manager, i.e. you’ve neither linked another instance by accident nor you’ve linked a prefab of the manager.
That’d explain the error.

You can check for multiple instances in the scene using T:GameManager (“T colon TComponent”) in the scene’s search bar, or use a Debug.Log statement to log the GO’s names of the GameManager.

Or simply click on the linked manager in your player to check where it is attached to.

If neither of both is the issue, something might mess up the lists, you should debug it in this case.

The elements in the list will be moved to close the gap, so there’ll be another one in place, if count was greater than 1.
Remove() does not behave like listWithTObject[index] = default(TObject).

1 Like
5

Thank You Suddoha!! yes I linked something wrong can’t say what i did wrong but it’s working!! i attempted something similar to resolve the error earlier but to no avail arghhh it’s always the little things!! Thank You buddy you just cured one major headache!! =L

6

Yeahh sorry for the poor explanation, I spent 30 minutes trying to make sure I made some sense =L I’m not used to having to explain my problems I usually find a solution before having to hit the forums, i’ll try word it better next time for sure, Thank You for your input buddy, everythings helps! =)

7

Thank You again but if you don’t mind me asking but when you said “(there’re some strange parts in your code though)”
if you got a moment could you point out these “strange parts” so maybe I can work about what I could do to improve on it.

8

You’re doing some operations that are very inefficient. Not necessarily noticeable, it’s not like they’re executed non-stop , but there are other types of collections and/or techniques to achieve this more elegantly.

Additionally there’re quite alot of redundant code parts which could be simplified. Unfortunately I don’t have any time today, perhaps I can point out some of these in greater detail tomorrow.

1 Like
9

That’s quite alright =) with what you just told me gives me an idea of what I need to be looking into… hitting some more books that’s for sure, time to get everything simple & elegant =) cheers dude!

1 Like
10

I can see 3 small things off the top of my head that could be changed easily for a little organization.

  1. You can group say lines 45 and 53 (from your post) based on the parts that match, and inside that ‘if statement’, have your other conditions
  2. with your tag checks:
    a) - you can use ‘else if’ on the second one.
    b) - use “other.gameObject.CompareTag” instead of “==”
    :slight_smile:
1 Like
11

Awesome Cheers Buddy! made all those changes, never thought of grouping the input, much easier on the eye.

Yeahh I had a feeling there was something more appropriate, “==” is more expensive to use I assume?

12

Cool, cool. :slight_smile: I think the grouping is a little easier to read, plus you cut down slightly on having to re-check your values. heh.

Ya, I mean it’s small, just a good habit, I suppose. When you return the tag (as a string) to compare, that’s a new string, whereas the compare tag just checks and returns true/false for ya.

1 Like
13

Definitely easier to read and makes more sense! just going through everything else i’m using to see if I can clear them up too.

Yeahh that makes sense awesome, i’m going to try do my best to make improvements where ever they can be applied, think I also need to get in the habit of actually reading what I write & deciding whether I actually need it =L Cheers for your help buddy Legendary! =)